[pgk/ottl] Remove debug log from invalidComparison #31813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
requested review from
bogdandrutu,
evan-bradley and
a team
as code owners
TylerHelmuth
added
the
Skip Changelog
crobert-1
approved these changes
Mar 18, 2024
atoulme
approved these changes
Mar 18, 2024
|
@evan-bradley please take a look |
ycombinator
pushed a commit
to ycombinator/opentelemetry-collector-contrib
that referenced
this pull request
Apr 9, 2024
) **Description:** When we added the boolean comparison feature we included a debug log to help troubleshoot when 2 comparisons were invalid, such as checking if a `string` was equal to a `float64`. Since then we've had complaints about how noisy the log is, mainly because it happens when checking against `nil`, which happens frequently when checking if an attribute has a specific value when it is present. This PR removes the log. **Link to tracking Issue:** Closes open-telemetry#29015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When we added the boolean comparison feature we included a debug log to help troubleshoot when 2 comparisons were invalid, such as checking if a
stringwas equal to afloat64. Since then we've had complaints about how noisy the log is, mainly because it happens when checking againstnil, which happens frequently when checking if an attribute has a specific value when it is present.This PR removes the log.
Link to tracking Issue:
Closes #29015