Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][connector/datadogconnector] Fix connector traceToMetrics lifecycle #31811

Merged
merged 7 commits into from Mar 19, 2024
Merged

[chore][connector/datadogconnector] Fix connector traceToMetrics lifecycle #31811

merged 7 commits into from Mar 19, 2024

Commits on Mar 18, 2024

  1. [chore][connector/datadogconnector] Fix connector traceToMetrics life… 

    …cycle

Currently, calling `Shutdown` on the `traceToMetricConnector` requires on `Start` being called before, as the `Shutdown` relies on goroutines which are spawned during `Start`. This causes the connector to hang if a call to `Shutdown` is made without a call to `Start`. This PR adds a `isStarted` field to the `traceToMetricConnector` struct, which tracks whether `Start` was called. If it was not, it makes the call to `Shutdown` a no-op.
    @mackjmr
    mackjmr committed Mar 18, 2024
    Copy the full SHA
    1760a6c View commit details
    Browse the repository at this point in the history

  2. run make gotidy

    @mackjmr
    mackjmr committed Mar 18, 2024
    Copy the full SHA
    25a2972 View commit details
    Browse the repository at this point in the history

  3. Update connector/datadogconnector/metadata.yaml 

    Co-authored-by: Antoine Toulme <antoine@toulme.name>
    @mackjmr @atoulme
    mackjmr and atoulme committed Mar 18, 2024
    Copy the full SHA
    77abc41 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec… 

    …tor-contrib
    @mackjmr
    mackjmr committed Mar 18, 2024
    Copy the full SHA
    23f34cf View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into fix-datadogconnector-lifecycle

    @mackjmr
    mackjmr committed Mar 18, 2024
    Copy the full SHA
    f053740 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'fix-datadogconnector-lifecycle' of github.com:mackjmr/o… 

    …pentelemetry-collector-contrib into fix-datadogconnector-lifecycle
    @mackjmr
    mackjmr committed Mar 18, 2024
    Copy the full SHA
    8e3f9a4 View commit details
    Browse the repository at this point in the history

  7. remove config

    @mackjmr
    mackjmr committed Mar 18, 2024
    Copy the full SHA
    cf7ba4e View commit details
    Browse the repository at this point in the history