Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] reuse the timer object when parsing #31802

Closed
wants to merge 4 commits into from
Closed

[chore] reuse the timer object when parsing #31802

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
069485b
[chore] reuse the timer object when parsing
atoulme Mar 18, 2024
1878d83
move after err
atoulme Mar 20, 2024
469b41c
remove default value, set by builder
atoulme Apr 5, 2024
bf139d6
separate constant reuse change
atoulme Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions pkg/stanza/operator/helper/time.go
View file
Open in desktop
Expand Up @@ -47,12 +47,10 @@ type TimeParser struct {

// Unmarshal starting from default settings
func (t *TimeParser) Unmarshal(component *confmap.Conf) error {
cfg := NewTimeParser()
err := component.Unmarshal(&cfg, confmap.WithIgnoreUnused())
err := component.Unmarshal(t, confmap.WithIgnoreUnused())
atoulme marked this conversation as resolved.
Show resolved Hide resolved
if err != nil {
return err
}
*t = cfg
return nil
}

Expand Down