Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] used UTC timezone in testcase #31798

Merged
merged 2 commits into from Mar 18, 2024
Merged

[bug] used UTC timezone in testcase #31798

merged 2 commits into from Mar 18, 2024

Conversation

ppalsingh
Copy link
Contributor

Description:
Test case should not use Local timezone, it should use UTC timezone.

Link to tracking Issue: #31797

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Mar 17, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot requested a review from kentquirk March 17, 2024 16:52
@TylerHelmuth
Copy link
Member

@ppalsingh please sign the cla

@TylerHelmuth TylerHelmuth added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 17, 2024
@ppalsingh
Copy link
Contributor Author

@ppalsingh please sign the cla

Done

Frapschen
Frapschen approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@Frapschen Frapschen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerHelmuth TylerHelmuth merged commit 1637886 into open-telemetry:main Mar 18, 2024
142 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 18, 2024
@crobert-1 crobert-1 mentioned this pull request Mar 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@Frapschen Frapschen Frapschen approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner

@kentquirk kentquirk Awaiting requested review from kentquirk

Assignees

@jpkrohling jpkrohling

Labels
pkg/ottl Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.97.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ppalsingh @TylerHelmuth @atoulme @Frapschen @jpkrohling