Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] fix mention of deprecated function in ecsobserver #31795

Merged
merged 2 commits into from Mar 18, 2024
Merged

[chore] fix mention of deprecated function in ecsobserver #31795

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23a7a8d
[chore] fix mention of deprecated function in ecsobserver
atoulme Mar 17, 2024
13e50c9
Merge branch 'main' into ecs_readme
atoulme Mar 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion extension/observer/ecsobserver/README.md
View file
Open in desktop
Expand Up @@ -443,7 +443,7 @@ otel's own /metrics.

### Error Handling

- Auth and cluster not found error will cause the extension to stop (calling `host.ReportFatalError`). Although IAM role
- Auth and cluster not found error will cause the extension to stop (calling `ReportStatus`). Although IAM role
can be updated at runtime without restarting the collector, it's better to fail to make the problem obvious. Same
applies to cluster not found. In the future we can add config to downgrade those errors if user want to monitor an ECS
cluster with collector running outside the cluster, the collector can run anywhere as long as it can reach scrape
Expand Down