[exporter/signalfx] Fix memory leaks #31772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Mar 17, 2024
|
This has passed 10+ times now without any failures. It should be ready to merge. |
atoulme
added
the
ready to merge
led0nk
pushed a commit
to led0nk/opentelemetry-collector-contrib
that referenced
this pull request
Mar 25, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Changes in PR: 1. Add correlation client Shutdown function that blocks on the waitgroup. This is the main fix of this PR that should fix the leaking goroutines. 2. Re-organize the shutdown process of the apm client correlation test suite to properly synchronize the shutting down process. 3. Fix typo 4. Only block request sender until context is cancelled. The request processor is shutdown when the context is cancelled, so this would result in `Shutdown` waiting forever, since the request would never be processed. 5. Enable goleak in some more packages. **Note**: This is contains the exact same contents as open-telemetry#30887, but change number 4 is new, and should resolve the test issue the original PR was causing. **Link to tracking Issue:** Resolves open-telemetry#30864 open-telemetry#30438 **Testing:** <Describe what testing was performed and which tests were added.> All existing tests are passing, as well as added goleak checks. I'm going to run this a number of times to try to help ensure it's not flaky anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes in PR:
Shutdownwaiting forever, since the request would never be processed.Note: This is contains the exact same contents as #30887, but change number 4 is new, and should resolve the test issue the original PR was causing.
Link to tracking Issue:
Resolves #30864
#30438
Testing:
All existing tests are passing, as well as added goleak checks. I'm going to run this a number of times to try to help ensure it's not flaky anymore.