address failures

cmd/oteltestbedcol/go.mod

@@ -394,5 +394,3 @@ replace github.com/open-telemetry/opentelemetry-collector-contrib/pkg/pdatautil
 replace github.com/openshift/api v3.9.0+incompatible => github.com/openshift/api v0.0.0-20180801171038-322a19404e37
 
 replace github.com/outcaste-io/ristretto v0.2.0 => github.com/outcaste-io/ristretto v0.2.1
-
-replace github.com/open-telemetry/opentelemetry-collector-contrib/extension/ackextension => ../../extension/ackextension

receiver/splunkhecreceiver/receiver.go

@@ -42,7 +42,6 @@ const (
 	responseOKWithAckID               = `{"text": "Success", "code": 0, "ackId": %d}`
 	responseHecHealthy                = `{"text": "HEC is healthy", "code": 17}`
 	responseInvalidMethodPostOnly     = `"Only \"POST\" method is supported"`
-	responseInvalidMethodGetOnly      = `"Only \"GET\" method is supported"`
 	responseInvalidEncoding           = `"\"Content-Encoding\" must be \"gzip\" or empty"`
 	responseInvalidDataFormat         = `{"text":"Invalid data format","code":6}`
 	responseErrEventRequired          = `{"text":"Event field is required","code":12}`
@@ -79,7 +78,6 @@ var (
 	invalidEncodingRespBody       = []byte(responseInvalidEncoding)
 	invalidFormatRespBody         = []byte(responseInvalidDataFormat)
 	invalidMethodRespBodyPostOnly = []byte(responseInvalidMethodPostOnly)
-	invalidMethodRespBodyGetOnly  = []byte(responseInvalidMethodGetOnly)
 	errGzipReaderRespBody         = []byte(responseErrGzipReader)
 	errUnmarshalBodyRespBody      = []byte(responseErrUnmarshalBody)
 	errInternalServerError        = []byte(responseErrInternalServerError)
@@ -293,7 +291,7 @@ func (r *splunkReceiver) handleAck(resp http.ResponseWriter, req *http.Request)
 
 	// check that the channel exists
 	partitionID := req.Header.Get(splunk.HTTPSplunkChannelHeader)
-	if len(partitionID) <= 0 {
+	if len(partitionID) == 0 {
 		r.failRequest(ctx, resp, http.StatusBadRequest, requiredDataChannelHeader, 0, nil)
 		return
 	}
@@ -337,7 +335,7 @@ func (r *splunkReceiver) handleRawReq(resp http.ResponseWriter, req *http.Reques
 	if r.ackExt != nil {
 		// check channel header exists
 		partitionID = req.Header.Get(splunk.HTTPSplunkChannelHeader)
-		if len(partitionID) <= 0 {
+		if len(partitionID) == 0 {
 			r.failRequest(ctx, resp, http.StatusBadRequest, requiredDataChannelHeader, 0, nil)
 			return
 		}
@@ -439,7 +437,7 @@ func (r *splunkReceiver) handleReq(resp http.ResponseWriter, req *http.Request)
 	if r.ackExt != nil {
 		// check channel header exists
 		partitionID = req.Header.Get(splunk.HTTPSplunkChannelHeader)
-		if len(partitionID) <= 0 {
+		if len(partitionID) == 0 {
 			r.failRequest(ctx, resp, http.StatusBadRequest, requiredDataChannelHeader, 0, nil)
 			return
 		}

receiver/splunkhecreceiver/receiver_test.go

@@ -1401,12 +1401,12 @@ func Test_splunkhecReceiver_handleRawReq_WithAck(t *testing.T) {
 			rcv, err := newLogsReceiver(receivertest.NewNopCreateSettings(), *config, sink)
 			assert.NoError(t, err)
 
-			mockHost := mockHost{extensions: map[component.ID]component.Component{
+			mh := mockHost{extensions: map[component.ID]component.Component{
 				id: tt.setupMockAckExtension(t),
 			}}
 
 			r := rcv.(*splunkReceiver)
-			assert.NoError(t, r.Start(context.Background(), mockHost))
+			assert.NoError(t, r.Start(context.Background(), mh))
 			defer func() {
 				assert.NoError(t, r.Shutdown(context.Background()))
 			}()
@@ -1519,11 +1519,11 @@ func Test_splunkhecReceiver_handleReq_WithAck(t *testing.T) {
 			r := rcv.(*splunkReceiver)
 			w := httptest.NewRecorder()
 
-			mockHost := mockHost{extensions: map[component.ID]component.Component{
+			mh := mockHost{extensions: map[component.ID]component.Component{
 				id: tt.setupMockAckExtension(t),
 			}}
 
-			assert.NoError(t, r.Start(context.Background(), mockHost))
+			assert.NoError(t, r.Start(context.Background(), mh))
 			defer func() {
 				assert.NoError(t, r.Shutdown(context.Background()))
 			}()