Updated MUI #362
Merged
Updated MUI #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the search bar in the dashboard component was removed from occupied component and given its own folder with associated styles
For easier readability and DX the developer icons sections was extracted into its own component and associated style sheet
Done to facilitate readablity and DX Styles also moved to ApplicationsCard component folder
Modularization
styles block at the top of occupied component was moved into a helper function. Tried to only switch the different styles (background-color, box shadow and another background color) Ran into trouble becuase those styles depend on the mode state which is defined in a context which cant be used outside a function component. Ended up just moving both styling functions whole
The modal component was being rendered multiple times which was unecessary. Additionally each modal component had a different state that was only being used to determine if that modal should be open or not. These states were condensed to one state to simplify the modal states
this commit represents the changes to all the individual modals that are now rendered from a single modal state. Done to clarify which modals are open and prevent unnecessary states
Modularization
fixed example bug
Clicking example now populates cards that are not wrapped in a link component. This allows the app to work the traditional way and with our example button. useNavigate hook was used in appplication card component to facilitate. Users can now also click exit example button to reset all states and use the app the traditional way.
Inside of application context add app was adjusted to render multiple cards at once. Each cards data is added to an object that is iterated over
Applications are now filtered inside of mapping function
…ved all global scss into index.scss
Cards are now deleted without the ref hook I believe the delRef hook was being used to prevent an issue with event bubbling. Becuase the delete button is nested inside of the Card component and card has an onClick the prior teams were calling the onClick on the card as well as the delete button. event.stopPropagation was used to prevent the bubbling the del ref hook is now able to be removed
Ted modular
Merge branch 'dev' of https://github.com/oslabs-beta/Chronos-MTSS into dev
Feature/example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Purpose
Approach
Learning
Screenshot(s)