test: post regression tests #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it looks great! I will hurry up with #69 |
|
#69 was merged :) Please rebase against master. Tip: Since only the last commit is needed here, I sugges to rebase using interactive mode (git rebase -i BASE) and drop all commits except the last EDIT: If master is already up to date, |
felipehuerta17
force-pushed
the
pr/post_reg_tests
branch
2 times, most recently
from
4de3cf5
to
b71e682
Compare
felipehuerta17
added
the
blocked
|
Is there a new dependency here with #77 or this one should be merged first? |
Creates a number of tests for input and model initialization validation to use confidence_intervals. As this is a function that requires a sequence of steps to be performed before, it is highly error prone and I think it is good to spend time developing tests for it as it bad use can produce misleading conclusions
felipehuerta17
force-pushed
the
pr/post_reg_tests
branch
from
b71e682
to
dc9d5be
Compare
felipehuerta17
force-pushed
the
pr/post_reg_tests
branch
from
dc9d5be
to
3a721f9
Compare
felipehuerta17
changed the title
felipehuerta17
removed
the
blocked
sasalatart
approved these changes
Jul 22, 2020
| @@ -144,6 +144,21 @@ def rolling_avg(x_list): | |||
| class ConfidenceIntervalsMixin: | |||
| """ Mixin with confidence interval definitions """ | |||
|
|
|||
| def is_initialized(self): | |||
| """ Checks that the model is initialized and fitted before calling | |||
| any postprocessing rotuine""" | |||
| instance before calculating confidence intervals" | ||
| ) | ||
|
|
||
| if (self.p is None) | (self.w0 is None): |
There was a problem hiding this comment.
Should this be an || instead?
There was a problem hiding this comment.
Maybe an or would be even better
| # ci_bootstrap | ||
| def test_ci_without_model_init(self, model): | ||
| """ Tests that an error is raised if the ci routines | ||
| are from an model instance that doesn't have initialized |
There was a problem hiding this comment.
Suggested change
| are from an model instance that doesn't have initialized | |
| are from a model instance that has not initialized |
| are from an model instance that doesn't have initialized | ||
| it parameters or initial conditions""" | ||
|
|
||
| # model.is_fitted = True |
There was a problem hiding this comment.
Should we remove this comment?
There was a problem hiding this comment.
Thanks! will implement the updates today
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I began the creation of tests for the confidence interval routines.
Note that this branch is branched from the PR #69, so it depends on merging that one.
We could potentially spend our whole life thinking on tests for confidence intervals so I am trying to write the most typical ones, such as providing incorrect inputs, not initializing the model or not fitting the model prior calling confidence intervals.
Still work in progress but some significant progress has been made. I am aware that this will require some rebase and so on.
Update 13/07/2020
The tests are now adequate to the latest version of
open-sir!