fix: fixed TS error and logic for gathering prompt response #3410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nickytonline
commented
May 16, 2024
brandonroberts
approved these changes
May 16, 2024
jpmcb
approved these changes
May 16, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
May 16, 2024
## [2.29.0](v2.28.0...v2.29.0) (2024-05-16) ### 🍕 Features * capture all StarSearch prompts in PostHog ([#3405](#3405)) ([f7d8ac6](f7d8ac6)) * implemented Enriched UI responses for StarSearch ([#3394](#3394)) ([9886681](9886681)) * only tag maintainers for the specific repo on repo pages ([#3395](#3395)) ([54c9a93](54c9a93)) ### 🐛 Bug Fixes * Change closed issue state to purple on issues table ([#3406](#3406)) ([71b4478](71b4478)) * correct placeholder text in HighlightInput component ([#3348](#3348)) ([2ea0d24](2ea0d24)) * fixed TS error and logic for gathering prompt response ([#3410](#3410)) ([36d26c2](36d26c2)) * remove unused waitlist components ([#3404](#3404)) ([a99b113](a99b113)) * styling repo pages layout ([#3398](#3398)) ([376de84](376de84))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prompt response had widgets added to them in #3372. Prior to that the prompt response was always a string. Now we concatenate the responses as it may include widgets where we serialize the widget data.
Related Tickets & Documents
Relates to #3405
Mobile & Desktop Screenshots/Recordings
N/A
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?