Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(next.config.js): rewrite image config #3400

Merged

Conversation

sourabpramanik
Copy link
Contributor

Description

This PR rewrites the deprecated image config to use remote images in the application

Related Tickets & Documents

chore #3376

Mobile & Desktop Screenshots/Recordings

None

Steps to QA

None

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Rewrite image config to use remote images in the application

chore open-sauced#3376
Copy link

netlify bot commented May 16, 2024

‼️ Deploy request for oss-insights rejected.

Name Link
🔨 Latest commit 450d577

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link

netlify bot commented May 16, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit c194c1e
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/664757921a2f7000092ca333
😎 Deploy Preview https://deploy-preview-3400--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great @sourabpramanik. Just one change request. Thanks for the cleanup!

next.config.js Outdated Show resolved Hide resolved
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sourabpramanik!

@nickytonline nickytonline merged commit ec2a53f into open-sauced:beta May 17, 2024
11 checks passed
@sourabpramanik sourabpramanik deleted the chore/nextjs-config-update branch May 18, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants