Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hammer/fix uat #869

Merged
merged 17 commits into from
Jan 9, 2024
Merged

Hammer/fix uat #869

merged 17 commits into from
Jan 9, 2024

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Jan 3, 2024

What's new

  • More logs for schedule times and conversions
  • using datetime.fromtimestamp(self.until.timestamp()))
  • test with changed pod timezone
  • export csv to designate semicolons as delimiters for Excel
  • fix schedule glitching due to logging
  • change logs to debug logs instead
  • disables unused and confusing start time field
  • lift op mode to mode, from lift state
  • additional schedule event viewer component for entire task description

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 1012 lines in your changes are missing coverage. Please review.

Comparison is base (fe0e808) 49.35% compared to head (b6918c2) 45.17%.
Report is 45 commits behind head on deploy/hammer.

Files Patch % Lines
packages/dashboard/src/components/map-app.tsx 0.00% 171 Missing ⚠️
.../dashboard/src/components/delivery-alert-store.tsx 0.00% 100 Missing ⚠️
...ackages/react-components/lib/tasks/create-task.tsx 0.00% 82 Missing ⚠️
...es/api-server/api_server/models/delivery_alerts.py 12.94% 74 Missing ⚠️
packages/react-components/lib/tasks/utils.ts 4.76% 54 Missing and 6 partials ⚠️
packages/dashboard/src/components/door-summary.tsx 0.00% 51 Missing ⚠️
...kages/dashboard/src/components/tasks/tasks-app.tsx 0.00% 51 Missing ⚠️
...shboard/src/components/tasks/task-cancellation.tsx 0.00% 48 Missing ⚠️
packages/dashboard/src/components/lift-summary.tsx 0.00% 47 Missing ⚠️
...ckages/api-server/api_server/repositories/tasks.py 37.31% 42 Missing ⚠️
... and 36 more
Additional details and impacted files
@@                Coverage Diff                @@
##           deploy/hammer     #869      +/-   ##
=================================================
- Coverage          49.35%   45.17%   -4.18%     
=================================================
  Files                285      291       +6     
  Lines               7564     8460     +896     
  Branches            1050     1338     +288     
=================================================
+ Hits                3733     3822      +89     
- Misses              3682     4439     +757     
- Partials             149      199      +50     
Flag Coverage Δ
api-server 74.92% <35.69%> (-5.88%) ⬇️
react-components 44.02% <16.14%> (-4.06%) ⬇️
rmf-auth ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…instead of utc_from_timestamp

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth changed the base branch from hammer/node-16 to deploy/hammer January 5, 2024 08:02
… jobs

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…le tab

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth marked this pull request as ready for review January 8, 2024 16:24
@aaronchongth aaronchongth merged commit d52c568 into deploy/hammer Jan 9, 2024
4 of 5 checks passed
@aaronchongth aaronchongth deleted the hammer/fix-uat branch January 9, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants