Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump k8s deps #202

Merged
merged 4 commits into from May 16, 2024
Merged

Conversation

JorTurFer
Copy link
Contributor

@JorTurFer JorTurFer commented Apr 26, 2024

This PR bumps k8s deps to v0.30.1 and all the required changes for them:

  • k8s.io/api@v0.30.1 requires go@1.22.0
  • go 1.22 requires linter upgrade

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JorTurFer
Copy link
Contributor Author

JorTurFer commented Apr 27, 2024

I've opened another PR just bumping to 0.29.4 as it doesn't require go changes, and maybe it's a good step in the middle to not force user to change too many versions at once: #203

@JorTurFer
Copy link
Contributor Author

JorTurFer commented Apr 27, 2024

It seems that v0.30.0 has a bug indeed kubernetes/kubernetes#124540

@tenzen-y
Copy link

@JorTurFer Hi, thank you for this great progressing!
Since it seems that v1.30.1 has been released, could we move this forward?

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
Copy link
Contributor Author

@maxsmythe PTAL, I've bumped k8s deps to 0.30.1

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Still LGTM!

@sozercan @ritazh LGTY?

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay. LGTM, thanks!

@sozercan sozercan merged commit 63dc0e4 into open-policy-agent:master May 16, 2024
6 checks passed
This was referenced May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants