Fix the info subscriber mechanism and hidden info keys #12498
Merged
+72
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devreal
force-pushed
the
fix-info-subscribe
branch
from
75c3ffa
to
cdda311
Compare
|
I verified that with this PR, HAN's info keys are properly propagated to the subcommunicators. |
bosilca
reviewed
Apr 27, 2024
opal/util/info.c
Outdated
| @@ -67,12 +67,14 @@ OBJ_CLASS_INSTANCE(opal_info_entry_t, opal_list_item_t, info_entry_constructor, | |||
| /* | |||
| * Duplicate an info | |||
There was a problem hiding this comment.
This is a major change, it deserves better documentation.
| @@ -85,6 +87,16 @@ int opal_info_dup(opal_info_t *info, opal_info_t **newinfo) | |||
| return OPAL_SUCCESS; | |||
| } | |||
|
|
|||
| int opal_info_dup_public(opal_info_t *info, opal_info_t **newinfo) | |||
There was a problem hiding this comment.
Move these into a header file and make them always inline.
There was a problem hiding this comment.
I'm hesitant about this since there are no other implementations in info.h. The call to opal_info_dup_impl will be a jmp so there is little to gain from inlining these.
There was a problem hiding this comment.
A call into a function that does a simple jmp ? I don't even see the interest of having these functions, with a weird name, instead of just using opal_info_dup with all 3 arguments.
devreal
force-pushed
the
fix-info-subscribe
branch
from
cdda311
to
cfac60e
Compare
Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
bosilca
force-pushed
the
fix-info-subscribe
branch
from
cfac60e
to
158e54c
Compare
bosilca
approved these changes
May 2, 2024
This was referenced May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #9246 was overzealous in dropping keys, which broke
MPI_[Comm|Win|File]_set_info. Also, @wenduwan noted in #11823 that info keys are not properly propagated to subcommunicators in HAN. The root cause is that keys are not kept if there were no subscribers.This PR makes the following changes:
__IN_prefix to the key, now it's a flag). Internal keys are not handed back to the user inMPI_[Comm|Win|File]_get_info.