ulfm: Fix use-after-free in ishrink implementation #12480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ompi_comm_request_return(req)` releases the internal `req->context`. Therefore, any `OBJ_RELEASE(context->xxx)` **MUST** be called **BEFORE** `ompi_comm_request_return()`, otherwise it is a use-after-free. Signed-off-by: Lisandro Dalcin <dalcinl@gmail.com>
dalcinl
force-pushed
the
bugfix/ulfm-comm-req-ret
branch
from
5011ac5
to
573f35e
Compare
|
There are more concerning issues with the code targeted by this PR (such as freeing a request that has been already given to the user level). We will audit the code and come up with a solution. If interested in knowing more please check #12479. |
|
@bosilca What should I do with this PR then? Should I just close it? |
|
Let's merge this, it fixes a problem that currently exists in main. |
bosilca
approved these changes
Apr 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ompi_comm_request_return(req)releases the internalreq->context. Therefore, anyOBJ_RELEASE(context->xxx)MUST be called BEFOREompi_comm_request_return(), otherwise it is a use-after-free.Follow up of #12384.
cc @bosilca @abouteiller