Update collective framework for bigcount #12478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosilca
reviewed
Apr 19, 2024
There was a problem hiding this comment.
I don't think this is the right approach, at least not for all the functions that take arrays of sizes and displacements. Indeed, this approach will force us to allocate/deallocate memory in the current API for in C and in Fortran, leading to serious performance implications.
Update the collective framework and dependent code to use size_t/ptrdiff_t for counts/displacements when necessary. Several places include comments with TODO:BIGCOUNT for changes that rely on updates to other libraries, such as the ompi/opal datatype code. Co-authored-by: Howard Pritchard <howardp@lanl.gov> Signed-off-by: Jake Tronge <jtronge@lanl.gov>
jtronge
force-pushed
the
coll-framework-bigcount
branch
from
ce4c5a5
to
7e40475
Compare
|
related to #12336 |
hppritcha
pushed a commit
to hppritcha/ompi
that referenced
this pull request
May 9, 2024
This commit adds only those functions which make use of C integer promotion. So none of the 'v,w' and reduce_scatter related methods are added in this PR. Related to open-mpi#12336 Pieces of open-mpi#12478 were taken out to make this PR. Signed-off-by: Howard Pritchard <howardp@lanl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should update the collective framework to use size_t/ptrdiff_t for counts/displacements. There are a few places that will need to be changed once other components are updated for bigcount (such as the opal/ompi datatype code) and these are indicated with
TODO:BIGCOUNTcomments.