datatype: Add support for MPI_TYPECLASS_LOGICAL #12424
Open
+51
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 7b93c9d: datatype: Add support for MPI_TYPECLASS_LOGICAL
64e5f5f: datatype: Add preliminary support for MPI_LOGICAL1...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
dalcinl
commented
Mar 21, 2024
| @@ -49,6 +49,7 @@ BEGIN_C_DECLS | |||
| #define OMPI_DATATYPE_FLAG_ANALYZED 0x0400 | |||
| #define OMPI_DATATYPE_FLAG_MONOTONIC 0x0800 | |||
| /* Keep trace of the type of the predefined datatypes */ | |||
| #define OMPI_DATATYPE_FLAG_DATA_BOOL 0x0000 /* TODO: what to do here? */ | |||
There was a problem hiding this comment.
I need help here. I've run out of space for an extra bit to distinguish boolean types. Can I shift everything up to make room? Would it be OK to shift by 4 bits, such that the bitmasks are still readable in hexadecimal?
Signed-off-by: Lisandro Dalcin <dalcinl@gmail.com>
Signed-off-by: Lisandro Dalcin <dalcinl@gmail.com>
|
I believe I forgot to bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for
MPI_TYPECLASS_LOGICALas being proposed in mpi-forum/mpi-issues#699.As a bonus, add preliminary support the
MPI_LOGICAL16datatype.TODO: Support for 128bit integral C types via GCC/LLVM
__int128extension.