Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accelerator null component must be static #12300

Merged
merged 1 commit into from Feb 6, 2024

Conversation

bosilca
Copy link
Member

@bosilca bosilca commented Feb 1, 2024

This component is always required and should not be influenced by the user defined mca_component_path.

This is a spinoff from the discussion on #12285

This component is always required and should not be influenced by the
user defined mca_component_path.

Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
Copy link
Member

@edgargabriel edgargabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can confirm that with this patch the null component is compiled statically, even if the --enable-mca-dso is added to the configure line.

@edgargabriel
Copy link
Member

shall we merge this pr?

@bosilca bosilca merged commit bcac86f into open-mpi:main Feb 6, 2024
11 checks passed
@bosilca bosilca deleted the fix/accelerator_null_always_static branch February 6, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants