Best targets #657
Merged
Best targets #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--best-memattr was very strict when selecting best nodes. The node had to be the best for the entire input CPUs. On a dual-socket machine with HBM in each socket, each HBM is the best local but not the best remote. Hence we'd report no best for the entire machine. Now we return both HBM for the entire machine by default, but may go back to the previous behavior by adding ",strict" after the attribute name. Adding ",default" also allows to return all nodes if no best was found (if no attribute values are found). Thanks to Antoine Morvan for the report. Refs open-mpi#652 Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
With support for best-node flags etc. Refs open-mpi#652 Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
Not used by hwloc-bind anymore. Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve --best-memattr in hwloc-calc/bind/info as discussed in #652
The API could be extended as well but it's not strictly required here yet. Maybe once this has been confirmed to help.