Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils/lstopo: don't build lstopo-win with MSVC #632

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

utils/lstopo: don't build lstopo-win with MSVC #632

wants to merge 2 commits into from

Commits on Oct 24, 2023

  1. utils/lstopo: remove -mwindows with MSVC 

    Clang can be used in "MSVC mode" to build hwloc using autotools.
That mode doesn't support -mwindows just like MSVC doesn't.

Closes open-mpi#631

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
    @bgoglin
    bgoglin committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    a248282 View commit details
    Browse the repository at this point in the history

  2. utils/lstopo: don't build lstopo-win with MSVC 

    Clang can be used in "MSVC mode" to build hwloc using autotools.
That mode doesn't support -mwindows just like MSVC doesn't.
-mwindows is the only difference between lstopo-win and lstopo,
so just disable lstopo-win instead of building both identically.

Closes open-mpi#631

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
    @bgoglin
    bgoglin committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    ca5d25a View commit details
    Browse the repository at this point in the history