Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP DNM] L0 always sysman #595

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[WIP DNM] L0 always sysman #595

wants to merge 5 commits into from

Commits on Jun 20, 2023

  1. levelzero: disable ZES_ENABLE_SYSMAN=1 when zesInit() is available 

    When zesInit() is available (starting in specs 1.5), we don't need
all the stuff to set ZES_ENABLE_SYSMAN=1 in the environment anymore.

This assumes that zesInit() works for real, which was not the case
in first compute-runtime releases (it returned "unsupported").
Those releases won't be supported anymore because they'd need
a runtime-check at configure time to find out that the ZES_ENABLE_SYSMAN=1
stuff must be enabled.

Only use a compile-check to switch between zesInit() and
ZES_ENABLE_SYSMAN=1, and tell users to avoid those L0 runtime
versions where zesInit() fails.

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
    @bgoglin
    bgoglin committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    36d3b61 View commit details
    Browse the repository at this point in the history

  2. levelzero: only get memory info from sysman 

    Now that zesInit() is available widely, don't bother falling back
to the core API if sysman wasn't enabled.

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
    @bgoglin
    bgoglin committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    09b5f13 View commit details
    Browse the repository at this point in the history

  3. levelzero: only get pci locality info from sysman 

    Now that zesInit() is available widely, don't bother falling back
to the core API if sysman wasn't enabled.
Hence remove the zeDevicePciGetPropertiesExt() optional detection

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
    @bgoglin
    bgoglin committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    1b3f6c7 View commit details
    Browse the repository at this point in the history

  4. levelzero: remove some warnings about missing sysman 

    Now that zesInit() is widely available, reduce the complexity
of the code in case sysman isn't enabled. Just keep a rather
vague warning in hwloc__levelzero_properties_get().

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
    @bgoglin
    bgoglin committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    c003c2f View commit details
    Browse the repository at this point in the history

  5. levelzero: remove the setting of ZES_ENABLE_SYSMAN=1 

    Now that zesInit() is widely available, remove all the stuff trying
to set ZES_ENABLE_SYSMAN=1 in the environment early.
If people really cannot use a recent runtime with zesInit(),
they should take care of setting ZES_ENABLE_SYSMAN=1.

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
    @bgoglin
    bgoglin committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    980e829 View commit details
    Browse the repository at this point in the history