New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selecting default and several nodes with --best-memattr #652
Comments
Hello. |
Here's a proposal for hwloc-calc (there's no change in the API yet, although I initially thought it would be strictly required). On a SPR+HBM machine in SNC-4, we now return 4 local HBMs when askling for best bandwidth nodes near an entire socket:
Previous releases returned nothing, and this behavior can still be obtained by adding a strict parameter There's also a default flag to return all nodes if no best is found. For instance on my laptop:
If that answers your need, I'll cleanup and document all this before preparing a PR. |
Looks like it is indeed answering my needs 👍 |
--best-memattr was very strict when selecting best nodes. The node had to be the best for the entire input CPUs. On a dual-socket machine with HBM in each socket, each HBM is the best local but not the best remote. Hence we'd report no best for the entire machine. Now we return both HBM for the entire machine by default, but may go back to the previous behavior by adding ",strict" after the attribute name. Adding ",default" also allows to return all nodes if no best was found (if no attribute values are found). Thanks to Antoine Morvan for the report. Closes open-mpi#652 Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
--best-memattr was very strict when selecting best nodes. The node had to be the best for the entire input CPUs. On a dual-socket machine with HBM in each socket, each HBM is the best local but not the best remote. Hence we'd report no best for the entire machine. Now we return both HBM for the entire machine by default, but may go back to the previous behavior by adding ",strict" after the attribute name. Adding ",default" also allows to return all nodes if no best was found (if no attribute values are found). Thanks to Antoine Morvan for the report. Refs open-mpi#652 Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
With support for best-node flags etc. Refs open-mpi#652 Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
Tarball should be available for testing at https://ci.inria.fr/hwloc/job/basic/job/PR-657/ soon |
--best-memattr was very strict when selecting best nodes. The node had to be the best for the entire input CPUs. On a dual-socket machine with HBM in each socket, each HBM is the best local but not the best remote. Hence we'd report no best for the entire machine. Now we return both HBM for the entire machine by default, but may go back to the previous behavior by adding ",strict" after the attribute name. Adding ",default" also allows to return all nodes if no best was found (if no attribute values are found). Thanks to Antoine Morvan for the report. Refs open-mpi#652 Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
With support for best-node flags etc. Refs open-mpi#652 Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
--best-memattr was very strict when selecting best nodes. The node had to be the best for the entire input CPUs. On a dual-socket machine with HBM in each socket, each HBM is the best local but not the best remote. Hence we'd report no best for the entire machine. Now we return both HBM for the entire machine by default, but may go back to the previous behavior by adding ",strict" after the attribute name. Adding ",default" also allows to return all nodes if no best was found (if no attribute values are found). Thanks to Antoine Morvan for the report. Refs #652 Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr> (cherry picked from commit 313de56) (with compile fixes forgotten in intermediate commits in master)
What version of hwloc are you using?
2.10.0
Which operating system and hardware are you running on?
RHEL 8; Linux 4.18
Details of the problem
Hello,
I am looking to allocate memory to the nodes showing best "attribute" among
This causes hwloc-calc to report no best memory for these attributes :
When I could like to print the firtst one (or best, all. see below).
Also, when all nodes have the same value for a given attribute, this command only returns the first one.
# Working fine when attribute has value : $ hwloc-calc --oo --local-memory --best-memattr Localilty socket:0 NUMANode:0
When actually they are all best memory.
This is asking 2 things:
--best-memattr
answer a list of nodes whenever they have the same value ?Best.
The text was updated successfully, but these errors were encountered: