Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix mix training on Ascend NPU #3215

Merged
merged 1 commit into from Jul 22, 2023
Merged

[Fix] Fix mix training on Ascend NPU #3215

merged 1 commit into from Jul 22, 2023

Conversation

xuuyangg
Copy link

@xuuyangg xuuyangg commented Jul 20, 2023

Motivation

Address an issue where mix training is not enabled when optimizer_config is present in the config on Ascend NPU

Modification

Previously, mix training was not enabled when optimizer_config was present in the configuration on Ascend NPU. This commit addresses the issue by ensuring that mix training is enabled under these circumstances.

Use cases

It has been validated on the knet_s3_upernet_swin-l_8x2_640x640_adamw_80k_ade20k.py config.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Jul 20, 2023

CLA assistant check
All committers have signed the CLA.

@xuuyangg xuuyangg changed the title [Fix] Enable mix training in ascend platform when optimizer_config ex… [Fix] Fix mix training on Ascend NPU Jul 21, 2023
@Ginray
Copy link

Ginray commented Jul 21, 2023

/lgtm

@xiexinch xiexinch merged commit f67ef9c into open-mmlab:0.x Jul 22, 2023
8 of 27 checks passed
@OpenMMLab-Assistant-004

Hi @xuuyangg,

We'd like to express our appreciation for your valuable contributions to the mmsegmentation. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants