Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in dice loss when there exist ignored pixels #2996

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Johnson-Wang
Copy link
Contributor

Motivation

Fix a bug in dice loss when there exist ignored pixels. Say we have pred=[0, 0, 0], binary mask=[0, 0, 1], valid_mask=[0, 0, 0], meaning that all labels are ignored. The expected dice loss should be 0. However, the original code incorrectly outputs dice loss = 0.5.

Checklist

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.

@Johnson-Wang Johnson-Wang changed the base branch from main to master May 9, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants