Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config and data convert function for occlusion-aware-face-dataset #2313

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

jinwonkim93
Copy link

@jinwonkim93 jinwonkim93 commented Nov 16, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.
Add config to enhance performance
add dataset convert function for original CelebA-mask dataset

Modification

Please briefly describe what modification is made in this PR.
add config
change config file name to follow paper naming.
add dataset convert file
update prepare.md

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@jinwonkim93 jinwonkim93 reopened this Nov 16, 2022
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
mmseg/datasets/__init__.py 100.00% <100.00%> (ø)
mmseg/datasets/face.py 80.00% <80.00%> (ø)

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@xiexinch
Copy link
Collaborator

Hi @jinwonkim93,
Thanks for updating the config files, we'll do some experiments and then feedback to you :)

@jinwonkim93
Copy link
Author

jinwonkim93 commented Jan 7, 2023

Hi @jinwonkim93, Thanks for updating the config files, we'll do some experiments and then feedback to you :)

Have any news about this? @xiexinch

aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants