Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] fix typo in migration.md #1739

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Docs] fix typo in migration.md #1739

wants to merge 1 commit into from

Conversation

eltociear
Copy link

@eltociear eltociear commented Aug 2, 2023 •
edited

Motivation

Fixed typo.

Modification

splited -> splitted

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@eltociear
[Docs] fix typo in migration.md
c0a9c98 
splited -> splitted
fangyixiao18
fangyixiao18 requested changes Aug 3, 2023
View reviewed changes
docs/en/migration.md
@@ -358,7 +358,7 @@ model = dict(

Changes in **`data`**:

- The original `data` field is splited to `train_dataloader`, `val_dataloader` and
- The original `data` field is splitted to `train_dataloader`, `val_dataloader` and
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be split, not splited or splitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fangyixiao18 fangyixiao18 fangyixiao18 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eltociear @fangyixiao18