Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Support for newer Python: Remove pickle5 dependency and Update mmcv maximum version #366

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

Wei-Chen-hub
Copy link
Collaborator

Pickle5 is not supported under Python version > 3.9, which would raise error in installing MMhuman3d in newer python.

@Wei-Chen-hub Wei-Chen-hub changed the title Remove pickle5 dependency [Fix] Support for newer Python: Remove pickle5 dependency and Update mmcv maximum version Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9431add) 85.33% compared to head (ae8646b) 85.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #366   +/-   ##
=======================================
  Coverage   85.33%   85.33%           
=======================================
  Files         211      211           
  Lines       20262    20262           
=======================================
  Hits        17290    17290           
  Misses       2972     2972           
Flag Coverage Δ
unittests 85.33% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
mmhuman3d/__init__.py 76.47% <100.00%> (ø)
mmhuman3d/data/data_converters/agora.py 88.17% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsonghua
Copy link

Hello, has this merger been completed?

When I tried to install it in the environment of py3.9, torch2.2.2, and CUDA12.4, pickle5-related errors still appeared

Failed to build pickle5
ERROR: Could not build wheels for pickle5, which is required to install pyproject.toml-based projects

in the last step of the tutorial.

cd mmhuman3d
pip install -v -e .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants