Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support AMP in box_iou_rotated #2899

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nijkah
Copy link
Contributor

@nijkah nijkah commented Aug 14, 2023

Motivation

Currently, box_iou_rotated does not support fp16 type.

Modification

Support AMP in box_iou_rotated.

Note that this PR does not support AMP for diff_iou_rotated_2d.
I tried to support it, but it is quite challenging to prevent overflow and underflow in complex operations.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@nijkah nijkah changed the base branch from main to 2.x August 14, 2023 07:33
@nijkah nijkah closed this Aug 14, 2023
@nijkah nijkah reopened this Aug 14, 2023
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouzaida zhouzaida changed the base branch from 2.x to main September 20, 2023 02:22
@nijkah nijkah requested a review from grimoire November 1, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants