Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix softmax focal loss algorithm #2893

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

qingpeng9802
Copy link

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

about #2892
fix softmax focal loss algorithm

Modification

same above

BC-breaking (Optional)

The original softmax focal loss algorithm is totally changed.

Use cases (Optional)

No change

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

Signed-off-by: Qingpeng Li <qingpeng9802@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Aug 7, 2023

CLA assistant check
All committers have signed the CLA.

@grimoire
Copy link
Member

@grimoire
Copy link
Member

Since focal loss is widely used in other repos. We better assign more reviewer from these repos @zhouzaida

@OpenMMLab-Assistant-004

Hi @qingpeng9802,

We'd like to express our appreciation for your valuable contributions to the mmcv. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!

Signed-off-by: Qingpeng Li <qingpeng9802@gmail.com>
Signed-off-by: Qingpeng Li <qingpeng9802@gmail.com>
Signed-off-by: Qingpeng Li <qingpeng9802@gmail.com>
@qingpeng9802 qingpeng9802 mentioned this pull request Aug 30, 2023
2 tasks
eliminate race condition

Signed-off-by: Qingpeng Li <qingpeng9802@gmail.com>
Signed-off-by: Qingpeng Li <qingpeng9802@gmail.com>
Signed-off-by: Qingpeng Li <qingpeng9802@gmail.com>
Signed-off-by: Qingpeng Li <qingpeng9802@gmail.com>
Signed-off-by: Qingpeng Li <qingpeng9802@gmail.com>
@qingpeng9802
Copy link
Author

If there are no more comments about the implementation, I will add some tests.

@grimoire
Copy link
Member

Since focal loss is widely used in other repos in OpenMMLab. I am contacting maintainers of other repos to review this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants