New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix softmax focal loss algorithm #2893
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Qingpeng Li <qingpeng9802@gmail.com>
Test case can be added in https://github.com/open-mmlab/mmcv/blob/main/tests/test_ops/test_focal_loss.py |
Since focal loss is widely used in other repos. We better assign more reviewer from these repos @zhouzaida |
Hi @qingpeng9802, We'd like to express our appreciation for your valuable contributions to the mmcv. Your efforts have significantly aided in enhancing the project's quality. If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID". Thanks again for your awesome contribution, and we're excited to have you as part of our community! |
Signed-off-by: Qingpeng Li <qingpeng9802@gmail.com>
Signed-off-by: Qingpeng Li <qingpeng9802@gmail.com>
Signed-off-by: Qingpeng Li <qingpeng9802@gmail.com>
eliminate race condition Signed-off-by: Qingpeng Li <qingpeng9802@gmail.com>
Signed-off-by: Qingpeng Li <qingpeng9802@gmail.com>
Signed-off-by: Qingpeng Li <qingpeng9802@gmail.com>
Signed-off-by: Qingpeng Li <qingpeng9802@gmail.com>
If there are no more comments about the implementation, I will add some tests. |
Since focal loss is widely used in other repos in OpenMMLab. I am contacting maintainers of other repos to review this PR. |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
about #2892
fix softmax focal loss algorithm
Modification
same above
BC-breaking (Optional)
The original softmax focal loss algorithm is totally changed.
Use cases (Optional)
No change
Checklist
Before PR:
After PR: