Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create reviewer folder to add files #9

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

malvikasharan
Copy link
Member

Starting with review rubric

Paz to add more files

Copy link
Member

@yochannah yochannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! I had two small comments before I will merge: can we update the alt text for the screenshots, so that if anyone has a screen reader, they have an idea what is in the image? An example for the first one in reviewer-instructions.md would be A page with a popup dialogue that says "you have chosen to accept this invitation. Do you want to continue?"

@yochannah
Copy link
Member

hah, I submitted too early. The second comment was to maybe not embed the dates in the text. I'm less sure about this one, to be honest, but I've noticed that going through text to update from OLS-3 to OLS-4 to OLS-5 is surprising time consuming. Where possible I've tried to say things like "when you sign up to OLS" rather than "when you sign up to OLS-6" to reduce admin burden.

In this case, dates are useful, of course! Maybe have a separate file with a list of deadlines and link to it?

Happy to be argued with on this one, and this comment shouldn't delay merging. The alt-text on above should!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants