Fix: add package queries #2902
Open
Fix: add package queries #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could adding FairEmail App be considered? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Detecting installed apps is currently not working properly. Since API level 30+, we need to specifically add the package IDs to query in the app manifest as described here.
Motivation and Context
In order to fix installed app detection.
How Has This Been Tested?
By installing the advertised apps.
Screenshots (if appropriate):
This screenshot shows the current behavior when Conversations and K9 is installed, and K9 is already set up with OpenKeychain. Both are not detected as installed (tapping them will open the download pages) and the already set up K9 is only displayed as package ID instead of the correct app name.
Types of changes