Minor changes in Readme #499
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: megha070 <varshney.megha070@gmail.com>
|
@bmpotter existing readme consists of postgres installation instructions for Mac OS but not Linux. Shall I include those too? |
bmpotter
requested changes
May 22, 2021
| @@ -53,6 +53,7 @@ export EXCHANGE_ROOTPW=myrootpw | |||
| ``` | |||
| export EXCHANGE_KEY_PW=<pass-phrase> | |||
| make gen-key | |||
| Note : pass-phrase can be any alphanumeric string | |||
There was a problem hiding this comment.
Are you sure special characters aren't allowed?
There was a problem hiding this comment.
I need to confirm this once.
Comment on lines
+69
to
+70
| - Before exporting below environment variables manually set them in `src/test/bash/primedb.sh` | ||
|
|
There was a problem hiding this comment.
I don't understand this sentence. primedb.sh gets these variables from the environment at
exchange-api/src/test/bash/primedb.sh
Line 40 in b905464
primedb.sh
| ``` | ||
| export EXCHANGE_USER=<my-user-in-IBM-org> | ||
| export EXCHANGE_PW=<my-pw-in-IBM-org> | ||
| export EXCHANGE_ROOTPW = <Exchange root password (Must be similar to what is set in exchange's config.json)> |
There was a problem hiding this comment.
The Preconditions section already tells them to set EXCHANGE_ROOTPW
There was a problem hiding this comment.
Oh yes, I missed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: megha070 varshney.megha070@gmail.com