Suggested fixes for System Taxonomies #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to ensure that we're using the correct Taxonomy and ObjectTag class types
pomegranited
commented
Jul 24, 2023
| @@ -52,6 +52,7 @@ | |||
|
|
|||
| AUTHENTICATION_BACKENDS = [ | |||
| 'rules.permissions.ObjectPermissionBackend', | |||
| 'django.contrib.auth.backends.ModelBackend', | |||
There was a problem hiding this comment.
I had to add this so that Django would let me login to the Admin?
pomegranited
commented
Jul 24, 2023
| @@ -29,7 +29,7 @@ def setUp(self): | |||
| self.taxonomy = Taxonomy.objects.get(name="Life on Earth") | |||
| self.system_taxonomy = Taxonomy.objects.get( | |||
| name="System defined taxonomy" | |||
| ).cast() | |||
| ) | |||
There was a problem hiding this comment.
Suggested removing this so that the test_rules are testing with an un-cast system taxonomy, so we know the rules are handling the cast.
pomegranited
commented
Jul 24, 2023
| @@ -556,7 +558,6 @@ def tag_ref(self, tag_ref: str): | |||
| try: | |||
| self.tag = self.taxonomy.tag_set.get(pk=tag_ref) | |||
| self.value = self.tag.value | |||
| return | |||
There was a problem hiding this comment.
nit: not needed anymore
and fixes nit
pomegranited
force-pushed
the
jill2/chris/system-defined-taxonomies
branch
from
5b8a210
to
9a9e038
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.