feat(condo): INFRA-202 multiple database sources #4618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sitozzz
commented
Apr 15, 2024
•
sitozzz
commented
- Need to deal with adapter cache!!!
- Stand tests
- Load tests
sitozzz
force-pushed
the
feat/condo/INFRA-202/multiple-database-sources
branch
5 times, most recently
from
6a93b34
to
db441c8
Compare
sitozzz
force-pushed
the
feat/condo/INFRA-202/multiple-database-sources
branch
3 times, most recently
from
1f957e4
to
046aaa6
Compare
sitozzz
added
👶 small
pahaz
reviewed
May 6, 2024
| run: | | ||
| docker run -e POSTGRES_USER=$POSTGRES_USER -e POSTGRES_PASSWORD=$POSTGRES_PASSWORD -e POSTGRES_DB=$POSTGRES_DB -p="127.0.0.1:5432:5432" -d swr.ru-moscow-1.hc.sbercloud.ru/doma/utils/postgres:13.2 | ||
| touch ./pg_hba.conf |
There was a problem hiding this comment.
This script looks very complex. Ideally, I'd like to see something like docker-compose up postgres postgres-replica, and all the magic with replication should happen automatically. This way, there's no need to do it all manually in CI, and it can be properly tested locally.
There was a problem hiding this comment.
Yup, that's true. But for now we can't run compose modules with self-hosted runner. This will be fixed in the future updates
sitozzz
force-pushed
the
feat/condo/INFRA-202/multiple-database-sources
branch
3 times, most recently
from
86f7aa3
to
1ff970a
Compare
…ections handling option [SQUASH THIS COMMIT DUE TO TEST CHANGES]
…using ScalableDatabaseAdapter
…l mapping function due to api changes
sitozzz
force-pushed
the
feat/condo/INFRA-202/multiple-database-sources
branch
from
db580d7
to
04db392
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.