Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(condo): DOMA-8440 add invoice number to payments export #4446

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

VKislov
Copy link
Contributor

@VKislov VKislov commented Mar 5, 2024

  • export only selectedRows if it is not empty
  • fix gql to display unitName in invoice payment export
  • add invoice number to payments export

There is a need to display the invoice number in the upload of payments for invoices. I decided to expand the existing template rather than create a separate one for invoices. I chose this solution for two reasons. Firstly, adding a new template will complicate the mutation logic and make it difficult for other developers to understand what is happening. Secondly, Payment has such a field, but it is not required, so if the upload has an empty column, this is normal, since this field is present in the entity. However, there is also a minus. Unloading payments by receipts will always have an empty invoice column

Copy link
Contributor

@Alllex202 Alllex202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also update tests for export

Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants