Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to OWLAPI 4.5.6 #355

Merged
merged 2 commits into from Oct 15, 2018
Merged

Conversation

beckyjackson
Copy link
Contributor

See #308

@jamesaoverton
Copy link
Member

@cmungall This should fix #308 and enables a feature I would like #185.

Protégé is still on 4.2.8 https://github.com/protegeproject/protege/blob/master/pom.xml#L131

Do you think we should update?

@cmungall
Copy link
Contributor

cmungall commented Sep 4, 2018

cc @matthewhorridge, I made a PR on the Protege repo but I'm guessing there are other considerations besides passing travis, all plugins need to be compatible.

I feel that there are some subtle obo format reordering changes going between 4.2.x and 4.3.x and above, when there are multiple axiom annotations. I will investigate.

@matthewhorridge
Copy link

@cmungall I'm looking into this... there are some class loading issues that prevent Protege from starting and right now I don't know whether I'm doing something wrong or whether it's new custom DI mechanism in the OWL API that doesn't play nicely with OSGi. Let me know how you get on with the ordering changes.

@matthewhorridge
Copy link

Copying in @ignazio1977

@cmungall
Copy link
Contributor

cmungall commented Sep 4, 2018

Thanks everyone. I'm guessing this won't make it into Protege 5.5?

Even so I think it's OK for you to go ahead if you need this @rctauber, on projects that need parity between owlapi versions, I think we can manage this by pinning to the current robot release/docker for an interim period.

@matthewhorridge
Copy link

I'm guessing this won't make it into Protege 5.5?

It will. Still in the beta period and, although this is a major change, I think it's important.

@matthewhorridge
Copy link

We'll do a few more tests here and then I'll merge in the owlapi-4.5.5 branch

@jamesaoverton
Copy link
Member

Protege moved to 4.5.6 (protegeproject/protege#800), so let's match that.

@beckyjackson
Copy link
Contributor Author

Switched to v4.5.6

@jamesaoverton jamesaoverton changed the title Update to OWLAPI 4.5.5 Update to OWLAPI 4.5.6 Sep 28, 2018
@jamesaoverton jamesaoverton merged commit fc6ef82 into ontodev:master Oct 15, 2018
@beckyjackson beckyjackson deleted the owlapi-update branch November 1, 2018 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants