Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix numpy dll missing issue with anaconda python on windows #317

Merged
merged 2 commits into from Feb 20, 2019

Conversation

nbcsm
Copy link
Collaborator

@nbcsm nbcsm commented Feb 20, 2019

unit test and pretrained model test with matrix are failing recently.
the root cause is:
anaconda updates its python package with dll lookup logic changed.
it causes numpy fails to find required dll on Windows.

more information here:
numpy/numpy#12957
ContinuumIO/anaconda-issues#10629

as a workaround, add numpy lib directory to path explicitly to resolve this issue.

eventually, we should use raw python instead of anaconda.
the reason that anaconda is used currently is: shared python so is missing for azure pipeline hosted agent, which causes onnxruntime failure.

@nbcsm nbcsm requested a review from pengwa February 20, 2019 08:32
@pengwa pengwa merged commit 0fbb359 into onnx:master Feb 20, 2019
@nbcsm nbcsm deleted the numpy branch February 20, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants