-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a tool to generate a time chart from an instrumentation file #2809
Open
negiyas
wants to merge
12
commits into
onnx:main
Choose a base branch
from
negiyas:pr_add_utils_timechart
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompiled by onnx-mlir with the "--InstrumentReportTime" option. Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com>
negiyas
changed the title
Add a tool to generate a time chart from an intrumentation file
Add a tool to generate a time chart from an instrumentation file
May 8, 2024
Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com>
Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com>
Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com>
Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com>
Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com>
Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com>
Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com>
AlexandreEichenberger
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
please confirm that help is provided if I type python make-time chart.py -h
?
Looking forward to use this tool, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a tool to generate a time chart figure from outputs generated by applications compiled by onnx-mlir with the "--InstrumentReportTime" option.
Users typically use
utils/make-timechart.py
with an instrumentation file. An output file in png format is generated. For example./utils/make-timechart.py resnet50-v2-7.inst
generatesresnet50-v2-7.png
The main graph shows a single folded time line for showing elapsed time of executed operations.
The Y-axis shows the beginning time of each horizontal line, and the X-axis shows time offsets to be added to the Y-axis.
The legend shows the total execution time and number of calls of each operation. As default, operations occupying 1.0%+ of execution time have independent legends, and other operations has a common "Other" legend.
Any comments and design requests are very welcome.
The following is an example scenario to compile, build, run a module and generate its timechart.