Add krnl prefetch #2786
Closed
Add krnl prefetch #2786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pass Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
|
cleaned up old dialect builder for affine prefetch that are not in use. |
chentong319
reviewed
Apr 16, 2024
| // Code lifted from affine prefetch as is. | ||
| // I have seen parsing errors when multiple '#x' are used in the indices, could | ||
| // not tell why. | ||
| // krnl.prefetch %arg0[%1#0, %1#1, %3], read, locality<3>, data : |
There was a problem hiding this comment.
How about affine.prefetch %arg0[%1#0, %1#1, %3], read, locality<3>, data ?
|
Got included as part of other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cannot add
affine.prefetchduring ONNX to KRNL lowering because affine prefetch check the enclosing loop nests, which are not yetaffine.forloops during KRNL lowering.Thus created a placeholder
krnl.prefetchthat will later be lowered toaffine.prefetch.