Make finding python version more robust #1927
Conversation
Signed-off-by: Nhat Nguyen <honguye@microsoft.com>
Signed-off-by: Nhat Nguyen <honguye@microsoft.com>
|
Can one of the admins verify this patch? |
|
If its ok with you, by updating the branch it get the latest and run the full tests (since I am an approved user for the Jenkins). You will have to refresh your local branch. |
| # is found. | ||
| if (POLICY CMP0094) | ||
| cmake_policy(SET CMP0094 NEW) | ||
| endif() |
There was a problem hiding this comment.
If this requires 3.15, the minimum required cmake version (currently 3.13.4) should be bumped up to 3.15.
There was a problem hiding this comment.
@gongsu832 would it be fine to bump to 3.15? Or are we help back to lower version because of some dependence?
@nhat-nguyen would you be willing to try moving us up to 3.15 if appropriate? Tx
There was a problem hiding this comment.
definitely, i can try moving us up to 3.15
There was a problem hiding this comment.
Actually we currently use 3.13.4 because that's what llvm uses. There is a comment in llvm that starting from llvm 17 they will require cmake 20.2 and they suggested to move up to 20.2 directly. This would require we move our Ubuntu base docker image from focal to jammy. I will create a PR to do that.
There was a problem hiding this comment.
@gongsu832 please link the PR so @nhat-nguyen will know when we may proceed with this one, thanks
|
There's now a PR to bump the min version to 3.20. See #2064 . This change could land after it completes. |
Starting from cmake 3.15, the Python_FIND_STRATEGY variable was introduced and can take 2 values:
LOCATION: stops lookup as soon as a suitable python version is found. This is theNEWbehavior for this policy.VERSION: finds the most recent python version. This is theOLDbehaviour or whenCMP0094is undefined.Using the
NEWpolicy will make our builds more robust because the most recent python version installed isn't necessarily compatible.Signed-off-by: Nhat Nguyen honguye@microsoft.com