Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JSON flow version output #567

Merged
merged 2 commits into from Mar 26, 2024
Merged

Use JSON flow version output #567

merged 2 commits into from Mar 26, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Mar 24, 2024 •
edited

Closes #564

Description

Use new JSON output and fallback to old method

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink added the improvement Technical work without new features label Mar 24, 2024
bthaile
bthaile approved these changes Mar 25, 2024
View reviewed changes
Copy link

@bthaile bthaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jribbink jribbink merged commit e0e3a2a into master Mar 26, 2024
3 of 6 checks passed
@jribbink jribbink deleted the jribbink/json-version branch March 26, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthaile bthaile bthaile approved these changes

Assignees
No one assigned
Labels
improvement Technical work without new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use JSON flow version output
2 participants
@jribbink @bthaile