Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block status input arg #393

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add block status input arg #393

wants to merge 1 commit into from

Conversation

Kay-Zee
Copy link
Member

@Kay-Zee Kay-Zee commented Feb 20, 2021

Works towards: #392

Description

One possible solution for #392

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@vercel
Copy link

vercel bot commented Feb 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/onflow/flow-docs/ht404sykd
✅ Preview: https://flow-docs-git-kan-add-block-status-input-arg.onflow.vercel.app

janezpodhostnik
janezpodhostnik approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the int to state mapping here (e.g. what value represents sealed)

@turbolent
Copy link
Member

agreed with @janezpodhostnik, maybe add an enum?

@psiemens
Copy link
Contributor

psiemens commented Jun 1, 2021

Is this PR still in progress @Kay-Zee?

@Kay-Zee
Copy link
Member Author

Kay-Zee commented Jun 29, 2021

not sure if this is still the solution we'd like to go with for solving #392

Any objections here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@lolpuddle lolpuddle lolpuddle approved these changes

@janezpodhostnik janezpodhostnik janezpodhostnik approved these changes

@vishalchangrani vishalchangrani Awaiting requested review from vishalchangrani

@psiemens psiemens Awaiting requested review from psiemens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Kay-Zee @turbolent @psiemens @lolpuddle @janezpodhostnik