Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Add new rpc endpoints #1451

Conversation

illia-malachyn
Copy link

@illia-malachyn illia-malachyn commented Apr 16, 2024

onflow/flow-go#5558

Added the following rpc endpoints:

  • SubscribeExecutionDataFromStartBlockID
  • SubscribeExecutionDataFromStartBlockHeight
  • SubscribeExecutionDataFromLatest

@illia-malachyn illia-malachyn force-pushed the illia-malachyn/5558-unify-data-execution-stream-endpoint branch 4 times, most recently from 78529d4 to 0fd55a5 Compare April 23, 2024 09:24
@illia-malachyn illia-malachyn changed the title Add appropriate types Add new rpc endpoints Apr 23, 2024
@illia-malachyn illia-malachyn marked this pull request as ready for review April 23, 2024 09:24
@illia-malachyn illia-malachyn force-pushed the illia-malachyn/5558-unify-data-execution-stream-endpoint branch from 0fd55a5 to 1b07702 Compare April 23, 2024 12:37
Copy link
Contributor

@Guitarheroua Guitarheroua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I left a few comments.

@illia-malachyn illia-malachyn force-pushed the illia-malachyn/5558-unify-data-execution-stream-endpoint branch from 1b07702 to 5418a77 Compare April 29, 2024 09:25
Added the following endpoints
- SubscribeExecutionDataFromStartBlockID
- SubscribeExecutionDataFromStartBlockHeight
- SubscribeExecutionDataFromLatest
@illia-malachyn illia-malachyn force-pushed the illia-malachyn/5558-unify-data-execution-stream-endpoint branch from 5418a77 to 8f1cc04 Compare April 29, 2024 09:48
@illia-malachyn illia-malachyn changed the title Add new rpc endpoints [Access] Add new rpc endpoints Apr 30, 2024
@peterargue peterargue merged commit 7db55ba into onflow:master May 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants