Update EVM support FLIP with new interface & Cadence 1.0 refactor #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramtinms
approved these changes
Feb 23, 2024
j1010001
pushed a commit
that referenced
this pull request
May 22, 2024
* evm support flip * fix typos * Apply suggestions from code review Co-authored-by: j pimmel <frankly.watson@gmail.com> * Apply suggestions from code review Co-authored-by: j pimmel <frankly.watson@gmail.com> * Apply suggestions from code review Co-authored-by: j pimmel <frankly.watson@gmail.com> * apply pr feedbacks * set issue number * Apply @turbolent's suggestions from his review Co-authored-by: Bastian Müller <bastian@dapperlabs.com> Co-authored-by: Greg Santos <greg.santos@dapperlabs.com> * apply PR feedback * Update protocol/20231116-evm-support.md * Reference uniqueness of BridgedAccount * Link to more tech information about Flow consensus * Apply suggestions from code review * Added image directory and EVM diagrams * Updated FLIP to reflect new naming * Added Flow EVM account model diagram * Further tidyup * Restore diagram from merge error * add language to code fences * document EVM.run * improve API * convert example script to transaction * update flip with recent changes * typos * typos * Apply suggestions from code review Co-authored-by: j pimmel <frankly.watson@gmail.com> * link to ERC-721 * Add line break * small improvements * change state toproposed * update isValid draft * link to ERC-1271 * fix deposite * Minor naming change Co-authored-by: Jeff Doyle <jeffrey.doyle@dapperlabs.com> * Update protocol/20231116-evm-support.md Co-authored-by: Gregor G. <75445744+sideninja@users.noreply.github.com> * Update EVM support FLIP with new interface & Cadence 1.0 refactor (#249) update EVM support FLIP * update evm contract * add status codes * update doc about run * add any evm address deposit to the contract * add details about the token bridge * Update deploy return type This change updates to latest changes to evm contract for coa.deploy function to return result, as well as updates the contract source to the latest * update Cadence 1.0 syntax * update deploy return result type * update email * deploy update comment * update deploy result optional * Update protocol/20231116-evm-support.md status * Add batch run to EVM FLIP (#257) Update 20231116-evm-support.md * updates to all the changes This commit contains updates that adds `dryRun` function, changes event type ID, changes event field values, adds secure random source Cadence arch method, adds `batchRun` function. * add dry run * update with events * add missing comma * revert status change, FLIP is not approved yet * update with hex-encoded events and revertible random * put back appendix c * make functions view * update view funcs --------- Co-authored-by: j pimmel <frankly.watson@gmail.com> Co-authored-by: Bastian Müller <bastian@dapperlabs.com> Co-authored-by: Greg Santos <greg.santos@dapperlabs.com> Co-authored-by: Bastian Müller <bastian@turbolent.com> Co-authored-by: Jeff Doyle <jeffrey.doyle@dapperlabs.com> Co-authored-by: Gregor G. <75445744+sideninja@users.noreply.github.com> Co-authored-by: Giovanni Sanchez <108043524+sisyphusSmiling@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding updated interface for EVM contract