New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FLIP 251: Cadence Date and Time #245
base: main
Are you sure you want to change the base?
Conversation
I think ignoring leap years is not a good idea. |
Agreed, we can probably at least support leap years, like e.g. Java's In general, we should not reinvent the wheel here and base the API and implementation of an established solution, like e.g. Java's JSR310 |
Yep, the current proposal is more based on the python datetime module. I wrongly made the assumption that they don't support leap years 🙁. I was just giving the wrong input with the year 2011 🤦 >>> datetime.datetime(2011, 2, 29)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ValueError: day is out of range for month Trying with an actual leap year works fine. >>> datetime.datetime(2024, 2, 29) |
Hi @darkdrag00nv2 - this FLIP is not reflected on FLIP project tracker. Did you follow the process outlined in https://github.com/onflow/flips? Specifically please remember to do the following without which the FLIP won't get visibility on the project tracker- Create an issue by using one of the FLIP issue templates based on the type of the FLIP - application, governance, cadence or protocol. The title of the issue should be the title of your FLIP, e.g., "Dynamic Inclusion fees". Submit the issue. Note the issue number that gets assigned. Thank you! |
#251
Work towards onflow/cadence#843