Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/reuse video capture component #1316

Merged
merged 181 commits into from
Apr 29, 2021
Merged

Improvement/reuse video capture component #1316

merged 181 commits into from
Apr 29, 2021

Conversation

ethan605
Copy link
Contributor

@ethan605 ethan605 commented Jan 22, 2021 •
edited

Problem

This is a prerequisite for #1315

Checklist

put n/a if item is not relevant to PR changes

  • Has the CHANGELOG been updated?
  • [n/a] Has the README been updated?
  • [n/a] Has the CONTRIBUTING doc been updated?
  • [n/a] Has the RELEASE_GUIDELINES been updated?
  • [n/a] Has the MIGRATION doc been updated for any MAJOR breaking changes?
  • [n/a] Has the MIGRATION doc been updated for any MINOR breaking changes, including any translation strings or keys changes?
  • [n/a] Have any new automated tests been implemented or the existing ones changed?
  • [n/a] Have any new manual tests been written down or the existing ones changed?
  • [n/a] Have any new strings been translated or the existing ones changed?

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://staging-1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://release-1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://staging-1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://release-1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://1316-pr-onfido-sdk-ui-onfido.surge.sh

@ethan605 ethan605 marked this pull request as ready for review January 22, 2021 15:08
@rfreitas
Copy link
Contributor

Travis automatic deployment: https://staging-1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://release-1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://staging-1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://release-1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://staging-1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://release-1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://staging-1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://release-1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://staging-1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://release-1316-pr-onfido-sdk-ui-onfido.surge.sh

stefaniacardenas
stefaniacardenas approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@stefaniacardenas stefaniacardenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://staging-1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://release-1316-pr-onfido-sdk-ui-onfido.surge.sh

kopijunkie
kopijunkie approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@kopijunkie kopijunkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://staging-1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://release-1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://release-1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://staging-1316-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor

Travis automatic deployment: https://1316-pr-onfido-sdk-ui-onfido.surge.sh

@github-actions
Copy link
Contributor

https://1316-pr-onfido-sdk-ui-onfido.surge.sh 🚀

@github-actions
Copy link
Contributor

https://1316-pr-onfido-sdk-ui-onfido.surge.sh 🚀

@stefaniacardenas stefaniacardenas merged commit 1723f91 into development Apr 29, 2021
@stefaniacardenas stefaniacardenas deleted the improvement/reuse-video-capture-component branch April 29, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefaniacardenas stefaniacardenas stefaniacardenas approved these changes

@kopijunkie kopijunkie kopijunkie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ethan605 @rfreitas @kopijunkie @stefaniacardenas