Safety improvements for email sending

Added return statements to email sending code to avoid exceptions on errors. This ensures attempted message sends will not cause further failures if an error occurs.
onetimesecret · Apr 30, 2024 · c1dd317 · c1dd317
1 parent a945d8d
commit c1dd317
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/lib/onetime/email.rb b/lib/onetime/email.rb
@@ -125,9 +125,11 @@ def send_email to_address, subject, content
       rescue Net::SMTPFatalError => ex
         OT.info "> [send-exception-smtperror] #{obscured_address}"
         OT.ld "#{ex.class} #{ex.message}\n#{ex.backtrace}"
+        return
       rescue => ex
         OT.info "> [send-exception-sending] #{obscured_address}"
         OT.ld "#{ex.class} #{ex.message}\n#{ex.backtrace}"
+        return
       end
 
       # Log the details