Implement notifications about idle threads #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the task_scheduler_observer interface with two new methods:
- on_scheduler_idle(), invoked when a worker does not have any tasks
to run and fails to steal any other tasks, before it goes to sleep;
- on_scheduler_active(), invoked when an idle worker finds a new task
to run, after it wakes from sleeping.
Extend the observer_list to notify all observer proxies about the idle
and active thread states.
Extend the task_dispatcher to notify about idle and active threads
before and after they go to sleep.
Signed-off-by: Andrea Bocci <andrea.bocci@cern.ch>
Use common implementations for do_notify_entry_observers/do_notify_idle_observers and for do_notify_exit_observers/do_notify_active_observers. Signed-off-by: Andrea Bocci <andrea.bocci@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend the
task_scheduler_observerinterface with two new methods:on_scheduler_idle(), invoked when a thread does not have any tasks to run and fails to steal any other tasks, before it goes to sleep;on_scheduler_active(), invoked when an idle thread finds a new task to run, after it wakes from sleeping.Extend the
observer_listto notify all observer proxies about the idle and active thread states.Extend the
task_dispatcherto notify about idle and active threads before and after they go to sleep.Fixes #992
Type of change
Tests
Documentation
Breaks backward compatibility
Does not break API compatibility, may break ABI compatibility for classes that inherit from
task_scheduler_observer.Notify the following users
@pavelkumbrasev
Other information