-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build against musl libc #899
base: master
Are you sure you want to change the base?
Conversation
Probably MALLOC_UNIXLIKE_OVERLOAD_ENABLED only works with glibc, so use __GLIBC__ in addition to __linux__ to define it.
can you link back to a build log of the failed compile, or a bug report where this is discussed? I was unable to reproduce with tbb-2021.7.0 |
The error:
|
so this is a test failure? |
Musl doesn't provide |
In any case, assuming anything based on |
Musl does provide some non-standard bits like function |
Is there specific macro for musl? If no, is it possible to pass it through cmake? |
No, musl doesn't define any such macros, intentionally. Isn't this GLIBC-specific anyway? The proper way would be to test the implementation to see if it's there, then define a macro based on that... but if that's not desirable, relying on the |
It seems that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ismaell Could you please update a copyright year from 2022 to 2023?
Description
Fix build against musl libc.
Probably
MALLOC_UNIXLIKE_OVERLOAD_ENABLED
only works withglibc
, so use__GLIBC__
in addition to__linux__
to define it.Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
Other information