Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ld: warning: cannot export hidden symbol typeinfo for tbb::detail::r1::unsafe_wait… #799

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phprus
Copy link
Contributor

@phprus phprus commented Mar 5, 2022

… from CMakeFiles/tbb.dir/exception.cpp.o

Signed-off-by: Vladislav Shchapov phprus@gmail.com

Description

macOS 12.1
Xcode 13.2.1

Linker warning:

ld: warning: cannot export hidden symbol typeinfo for tbb::detail::r1::unsafe_wait from CMakeFiles/tbb.dir/exception.cpp.o

Fixes #713

  • - git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details)

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

@phprus
Copy link
Contributor Author

phprus commented Mar 13, 2022

cc @anton-potapov

@anton-potapov
Copy link
Contributor

@phprus, thanks for the contribution! One thing bothers me a lot here - It seems we miss an understanding of what really is going on here, i,e, what forcing the compiler to issue the warning? is it known compiler bug/feature? Or our code breaking (probably unwritten) rules here?

@phprus
Copy link
Contributor Author

phprus commented Mar 14, 2022

@anton-potapov
unsafe_wait does not export any symbols from libtbb.dylib.
I think because of this the compiler/linker from xcode makes typeinfo hidden.

@phprus
Copy link
Contributor Author

phprus commented Sep 26, 2022

Xcode 14, same warning:

ld: warning: cannot export hidden symbol typeinfo for tbb::detail::r1::unsafe_wait from CMakeFiles/tbb.dir/exception.cpp.o

…l::r1::unsafe_wait from CMakeFiles/tbb.dir/exception.cpp.o

Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@phprus
Copy link
Contributor Author

phprus commented Dec 27, 2022

@pavelkumbrasev, @isaevil what do you think about this PR?

@phprus
Copy link
Contributor Author

phprus commented Jan 29, 2023

@pavelkumbrasev, @isaevil, @kboyarinov
ping?

@pavelkumbrasev
Copy link
Contributor

@phprus So is it only a warning?

@phprus
Copy link
Contributor Author

phprus commented Jan 30, 2023

@pavelkumbrasev
This is a warning.
All oneTBB tests pass successfully. But, I don't know if it affects anything else.

@phprus
Copy link
Contributor Author

phprus commented Mar 12, 2023

Xcode 14.3 Beta 2 has same warning.

@phprus
Copy link
Contributor Author

phprus commented Jun 3, 2023

More correct solution: #1114

@phprus phprus mentioned this pull request Jun 3, 2023
14 tasks
@phprus phprus marked this pull request as draft August 23, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ld: warning: cannot export hidden symbol typeinfo for tbb::detail::r1::unsafe_wait
3 participants